Xion Audio Player

[fixed: 98] Opening FLAC files from Explorer does not work

Fixed Bugs are moved here for archival purposes, usually marked with the build number they were fixed in.

Postby dredd » April 5th, 2008, 2:23 am

Looks like Xion has a problem with FLAC files given as a parameter. If it's called with such (for example by double clicking a file in Explorer) nothing happens, i. e. Xion starts but doesn't even load the file, if another file is being played it continues playing. If you drop the FLAC file on the player or into the playlist it works.

It works for me with other formats (at least mp3 and ogg, I haven't tested others) and I've reproduced this behaviour with different files on different machines, so I think it's a program error ...
dredd
Xion Supporter
 
Posts: 28
Joined: March 5th, 2008, 11:17 am

Postby SLoB » April 5th, 2008, 3:44 am

have you looked at the associate file types in the config?

depending on wot other media apps u use it might need to be set to xion, so try the above
User avatar
SLoB
Xion Junkie
 
Posts: 1340
Joined: September 11th, 2006, 9:21 pm
Location: UK

Postby dredd » April 5th, 2008, 4:17 am

I know, this looks like noob trouble ;) But the file type association is not the problem. Actually there's no difference if FLAC files are associated or not. The problem is, that for some reason Xion does not play the FLAC file its executable gets as a parameter when it is called. If you run

Code: Select All Code
xion.exe "path\to\the\file.flac"


it will start if not running, but it won't play the file, neither load it.

All that file type association does is running xion.exe with the file as a parameter. But as Xion fails to handle that, shell integration with FLACs doesn't work. The same with right click -> open with Xion, right click -> enqueue file in Xion, etc:

Code: Select All Code
xion.exe /enqueue "path\to\the\file.mp3"   <- working
xion.exe /enqueue "path\to\the\file.flac"  <- not working
dredd
Xion Supporter
 
Posts: 28
Joined: March 5th, 2008, 11:17 am

Postby SLoB » April 5th, 2008, 4:45 am

is this with the latest beta build 97 or with 95?

Cliff has fixed some things with files loading (but this specific issue might still be a bug)

best to check the beta forum section and try build 97
User avatar
SLoB
Xion Junkie
 
Posts: 1340
Joined: September 11th, 2006, 9:21 pm
Location: UK

Postby dredd » April 5th, 2008, 4:55 am

Already tried it, no difference ... :(
dredd
Xion Supporter
 
Posts: 28
Joined: March 5th, 2008, 11:17 am

Postby Cliff Cawley » April 5th, 2008, 9:10 am

Thanks for reporting this one, dredd!

I've fixed this for build 98, thanks to your report!

Cliff :)
Cliff Cawley
Creator of Xion
r2 Studios
http://www.r2.com.au
http://xion.r2.com.au
User avatar
Cliff Cawley
Creator of Xion
 
Posts: 1955
Joined: September 3rd, 2006, 11:33 am
Location: Brisbane, Australia

Postby dredd » April 5th, 2008, 6:26 pm

Thanks Cliff, works great!

Was this FLAC specific or might other formats be affected as well?
dredd
Xion Supporter
 
Posts: 28
Joined: March 5th, 2008, 11:17 am

Postby Cliff Cawley » April 6th, 2008, 9:53 am

dredd Wrote:Thanks Cliff, works great!

Was this FLAC specific or might other formats be affected as well?


It was file extension size specific ;)

I.e. when checking the supported file formats, I was quickly checking the last 4 characters, in this case, it was FLAC, instead of the expected .FLAC

So pretty much any file format that used more than 3 characters would not get loaded and any using less than 3 as well!

Anyway, I've fixed up the code to properly detect the file extension now :)

Cliff :)
Cliff Cawley
Creator of Xion
r2 Studios
http://www.r2.com.au
http://xion.r2.com.au
User avatar
Cliff Cawley
Creator of Xion
 
Posts: 1955
Joined: September 3rd, 2006, 11:33 am
Location: Brisbane, Australia

Postby SLoB » April 6th, 2008, 7:22 pm

heheh Cliff ;) naught naughty ;)
User avatar
SLoB
Xion Junkie
 
Posts: 1340
Joined: September 11th, 2006, 9:21 pm
Location: UK

Postby Cliff Cawley » April 6th, 2008, 7:36 pm

SLoB Wrote:heheh Cliff ;) naught naughty ;)


Yeah yeah, I think it started out as a test and then propagated from there, each time telling myself I need to fix that, then forgetting about it :D

Cliff :)
Cliff Cawley
Creator of Xion
r2 Studios
http://www.r2.com.au
http://xion.r2.com.au
User avatar
Cliff Cawley
Creator of Xion
 
Posts: 1955
Joined: September 3rd, 2006, 11:33 am
Location: Brisbane, Australia

Postby SLoB » April 6th, 2008, 8:45 pm

possibly one thing that might be lacking i think is peer code reviews, in a dev testing way not derogatory way

whereby code changes/fixes are reviewed and tested by another member of the dev team prior to it going to QA
this has the benefit of cross training devs in other areas of the system and also benefiting the team building a better product as mistakes or not so great code can be improved before it even hits the shelves so to speak
it also helps raise the level of development from the team
User avatar
SLoB
Xion Junkie
 
Posts: 1340
Joined: September 11th, 2006, 9:21 pm
Location: UK

Postby Cliff Cawley » April 6th, 2008, 11:43 pm

SLoB Wrote:possibly one thing that might be lacking i think is peer code reviews, in a dev testing way not derogatory way

whereby code changes/fixes are reviewed and tested by another member of the dev team prior to it going to QA
this has the benefit of cross training devs in other areas of the system and also benefiting the team building a better product as mistakes or not so great code can be improved before it even hits the shelves so to speak
it also helps raise the level of development from the team


Yeah, I totally agree. I'll just clone myself so I can review my work, since my dev team size is a total of umm.. ONE. Myself :lol:

Cliff :)
Cliff Cawley
Creator of Xion
r2 Studios
http://www.r2.com.au
http://xion.r2.com.au
User avatar
Cliff Cawley
Creator of Xion
 
Posts: 1955
Joined: September 3rd, 2006, 11:33 am
Location: Brisbane, Australia

Postby SLoB » April 7th, 2008, 5:56 am

i kno thats why i said it was lacking lol ;)

well u can always run code by me if u like as a second look, im pretty good at troubleshooting stuff, i always get my bug(s) lol, well 99.9% of the time, its in software's nature to be buggy innit lol, keeps ya in a job ;)
User avatar
SLoB
Xion Junkie
 
Posts: 1340
Joined: September 11th, 2006, 9:21 pm
Location: UK

Return to Bugs - Fixed

Who is online

Users browsing this forum: Yahoo [Bot] and 0 guests

cron